Opened 4 years ago

Closed 4 years ago

#32051 closed Bug (fixed)

Animation issues with rocket on Congrats new project page

Reported by: Thibaud Colas Owned by: Thibaud Colas
Component: Core (Other) Version: dev
Severity: Normal Keywords: accessibility, ui
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Thibaud Colas)

There are a number of issues with the rocket animation shown on the Congrats page. In no specific order,

  • The page take up between 10 and 30% of my CPU to render the animations on a MacBook Pro from 2015.
  • Firefox has a different animation from other browsers, where the rocket exhaust__line extends further than it should.
  • For other browsers (tested in Chrome and Safari on macOS), the smoke is cropped to the sides because of root-level SVGs being overflow: hidden.
  • The animation doesn’t respect `prefers-reduced-motion: reduce` (more of an enhancement).

I’ve taken a stab at addressing these, and cleaning up unused CSS and SVG, in https://github.com/django/django/pull/13463.

Attachments (3)

32051-rocket-animation-performance.gif (53.0 KB ) - added by Thibaud Colas 4 years ago.
Screenshot of the Chrome DevTools showing CPU usage with the animation
32051-rocket-firefox.png (43.9 KB ) - added by Thibaud Colas 4 years ago.
Screenshot of animation rendering in Firefox
32051-rocket-safari.png (42.0 KB ) - added by Thibaud Colas 4 years ago.
Screenshot of animation rendering in Safari

Download all attachments as: .zip

Change History (11)

by Thibaud Colas, 4 years ago

Screenshot of the Chrome DevTools showing CPU usage with the animation

by Thibaud Colas, 4 years ago

Attachment: 32051-rocket-firefox.png added

Screenshot of animation rendering in Firefox

by Thibaud Colas, 4 years ago

Attachment: 32051-rocket-safari.png added

Screenshot of animation rendering in Safari

comment:1 by Thibaud Colas, 4 years ago

Description: modified (diff)
Has patch: set

comment:2 by Thibaud Colas, 4 years ago

Summary: Animation issues with rocket on Congrats pageAnimation issues with rocket on Congrats new project page

comment:3 by Thibaud Colas, 4 years ago

Keywords: accessibility ui added
UI/UX: set

comment:4 by Thibaud Colas, 4 years ago

Description: modified (diff)

comment:5 by Mariusz Felisiak, 4 years ago

Owner: changed from nobody to Thibaud Colas
Status: newassigned
Triage Stage: UnreviewedAccepted

Thanks for this ticket.

comment:6 by Mariusz Felisiak, 4 years ago

Triage Stage: AcceptedReady for checkin

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 838e115a:

Refs #32051 -- Cleaned up CSS and SVG in the 'Congrats' page.

  • Removed unnecessary vendor prefixes.
  • Removed unused CSS and SVG code.
  • Removed invalid CSS.
  • Removed IE9-only browser reset styles.
  • Fixed animation on Firefox.

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: fixed
Status: assignedclosed

In b807298:

Fixed #32051 -- Fixed rocket animation on the 'Congrats' page.

  • Fixed congratulations smoke being cropped.
  • Refactored congratulation rocket so the animation can be stopped.
  • Made animation respect user preference for reduced animation.
  • Made rocket animation stop after 7s.
Note: See TracTickets for help on using tickets.
Back to Top