Opened 4 years ago

Closed 4 years ago

#31822 closed New feature (fixed)

Add support for item_comments to syndication framework

Reported by: Viktor Garske Owned by: Viktor Garske
Component: contrib.syndication Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Add comments argument to feed.add_item() in syndication.views so that item_comments can be defined directly without having to take the detour via item_extra_kwargs .

Additionally, comments is already explicitly mentioned in the feedparser, but not implemented in the view.

Change History (5)

comment:1 by Viktor Garske, 4 years ago

Has patch: set

comment:2 by Viktor Garske, 4 years ago

Version: 3.0 → master

comment:3 by Mariusz Felisiak, 4 years ago

Summary: Add support for item_comments dynamic attribute → Add support for item_comments to syndication framework
Triage Stage: Unreviewed → Accepted

Sounds reasonable, see ​RSS 2.0.

​PR

comment:4 by Mariusz Felisiak, 4 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 1173db4a:

Fixed #31822 -- Added support for comments URL per feed item.

The item_comments hook returns a comments URL which is then used by the
feed builder.

Note: See TracTickets for help on using tickets.
Back to Top