Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#31743 closed Cleanup/optimization (fixed)

Note that managed=false prevents modifications.

Reported by: Steven Pousty Owned by: Steven Pousty
Component: Documentation Version: 3.0
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Managed = false will also prevent modifications. This is made clear in the comments in the auto-generated output from inspectdb but is not mentioned here. This PR helps prevent the over half day wasted wondering makemigrations saw no changes when adding a new column to the table.

It would also be nice to add something to the first paragraph to make it clear that managed= True allows for modifications of the schema in the database.

Change History (4)

comment:1 by Mariusz Felisiak, 4 years ago

Has patch: set
Owner: changed from nobody to Steven Pousty
Status: newassigned
Summary: The Managed=True documentation is incompleteNote that managed=false prevents modifications.
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

It would also be nice to add something to the first paragraph to make it clear that managed= True allows for modifications of the schema in the database.

It's a different layer, IMO we don't need to clarify that you can modify tables outside of Django.

PR

comment:2 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: fixed
Status: assignedclosed

In d2c135d:

Fixed #31743 -- Doc't that managed=False prevents Django from managing tables modifications.

comment:3 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 1a3029b:

[3.1.x] Fixed #31743 -- Doc't that managed=False prevents Django from managing tables modifications.

Backport of d2c135da4c75079e45661ec609bd72f27dddf2a9 from master

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 9b908398:

[3.0.x] Fixed #31743 -- Doc't that managed=False prevents Django from managing tables modifications.

Backport of d2c135da4c75079e45661ec609bd72f27dddf2a9 from master

Note: See TracTickets for help on using tickets.
Back to Top