#31575 closed Bug (fixed)
Document admin's requirement on django.template.context_processors.request context processor.
| Reported by: | Jon Dufresne | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Since commit d24ba1be7a53a113d19e2860c03aff9922efec24, the admin templates use the implied request variable normally added by django.template.context_processors.request.
As Django templates silence errors, this went unnoticed during testing, and won't immediately break the templates, but certain expected rendering features won't work.
Django should document this change:
- In the release notes (provide a deprecation period where it is a warning only)
- In the admin docs
- In the system check framework as a warning (but eventually an error)
Change History (7)
comment:1 by , 5 years ago
| Has patch: | set |
|---|
comment:3 by , 5 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:4 by , 5 years ago
| Triage Stage: | Ready for checkin → Accepted |
|---|
Suggestion from Mariusz on the PR, to the system check an error but only if the sidebar is enabled.
comment:5 by , 5 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
https://github.com/django/django/pull/12906