#3152 closed enhancement (invalid)
[patch] Changed a few things in admin to allow overiding of list_per_page in admin
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | normal | Keywords: | paginator admin change_list |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
As per my post on django-developers here I've made a few changes to the ChangeList object (among other things) to add a field for specifying the number per page to show in the change_list view in admin.
The patch is against 4077 I'm afraid... I'm not yet comfortable with SVN to be all that confident about updating without shooting myself in the foot!
This patch also contains changes I've made to fix admin breaking when sorting on a FK with has an order_by specified as -something.
Attachments (1)
Change History (7)
by , 18 years ago
| Attachment: | number_per_page.diff added |
|---|
comment:1 by , 18 years ago
comment:2 by , 18 years ago
Ben,
Would you mind unfolding you proposed mods in two patches?: One implementing the feature you describe and attaching it to this ticket an another implementing the "This patch also contains changes I've made to fix admin breaking when sorting on a FK with has an order_by specified as -something." fix possibly creating a different ticket for that?.
It would make things easier fot the bug reviewers and it may raise the possibility of it being applied/closed/marked as duplicate/etc.
comment:3 by , 18 years ago
| Patch needs improvement: | set |
|---|---|
| Resolution: | → invalid |
| Status: | new → closed |
I'll close this enhancement request for now. If Ben or someone else wants to write a new patch, feel free to reopen.
comment:4 by , 18 years ago
I'm happy to re-do the patch... Could you indicate hat was wrong with it so I can fix it?
comment:5 by , 18 years ago
Good to hear, Ben. Start with Ramiro's suggestions and reopen with the new patch - thanks!
Ok, it looks like I've screwed up the diff slightly, but I hope it's enough to get the idea!