Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#31359 closed Cleanup/optimization (fixed)

Deprecate using get_random_string without an explicit length

Reported by: Claude Paroz Owned by: Claude Paroz
Component: Utilities Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

django.utils.crypto.get_random_string currently has a default length value (12). I think we should force callers to specify the length value and not count on a default.

Change History (5)

comment:1 by Claude Paroz, 5 years ago

Has patch: set

​PR

comment:2 by Mariusz Felisiak, 5 years ago

Owner: changed from nobody to Claude Paroz
Status: new → assigned
Triage Stage: Unreviewed → Accepted

comment:3 by Mariusz Felisiak, 5 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In e663f69:

Fixed #31359 -- Deprecated get_random_string() calls without an explicit length.

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In be6e4681:

Refs #31359 -- Made get_random_string()'s length argument required.

Per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top