Opened 5 years ago
Closed 5 years ago
#31314 closed Bug (fixed)
makemessages doesn't provide feedback when no locale is specified
| Reported by: | Cristóbal Mackenzie | Owned by: | Cristóbal Mackenzie |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | 3.0 |
| Severity: | Normal | Keywords: | i18n |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
makemessages requires that one of three flags be passed to specify locales for message building: --locale to explicitly specify locales, --exclude to specify locales to exclude, or --all to build message files for all locales.
When non of these flags are present, the command doesn't show any errors for the user. According to the source code, it should raise CommandError, but that never happens because of a bug in an if statement that checks if a locale has been specified.
I've already fixed this in my fork and have submitted a small PR.
https://github.com/django/django/pull/12503
Please point out if there are any other necessary steps to move this forward. Thanks!
Change History (4)
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 5 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 5 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Regression in 0707b824fe77e08ca8b75fcc3738ada694f2a3a6.