Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31307 closed Bug (fixed)

Arrow display error in filter_horizontal field when width less than 1024px

Reported by: 007 Owned by: 007
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Carlton Gibson)

when screen width less than 1024 filter_horizontal field add and remove arrow display error when mouse hover

Attachments (6)

1.png​ (40.9 KB ) - added by 007 5 years ago.
2.png​ (27.0 KB ) - added by 007 5 years ago.
767_1024_hover_remove_current .png​ (44.4 KB ) - added by 007 5 years ago.
767_1024_hover_remove_expected.png​ (45.9 KB ) - added by 007 5 years ago.
less_767_hover_remove_current.png​ (23.8 KB ) - added by 007 5 years ago.
less_767_hover_remove_expected.png​ (23.2 KB ) - added by 007 5 years ago.

Download all attachments as: .zip

Change History (17)

by 007, 5 years ago

Attachment: 1.png​ added

by 007, 5 years ago

Attachment: 2.png​ added

comment:1 by 007, 5 years ago

Type: Uncategorized → Bug

comment:2 by 007, 5 years ago

Has patch: set

comment:3 by Carlton Gibson, 5 years ago

Description: modified (diff)
Triage Stage: Unreviewed → Accepted

Yes, thanks for the report. I'm seeing this only for the Choose arrow, and not for Remove.

​PR.

by 007, 5 years ago

Attachment: 767_1024_hover_remove_current .png​ added

by 007, 5 years ago

Attachment: 767_1024_hover_remove_expected.png​ added

by 007, 5 years ago

Attachment: less_767_hover_remove_current.png​ added

by 007, 5 years ago

Attachment: less_767_hover_remove_expected.png​ added

in reply to:  3 comment:4 by 007, 5 years ago

Replying to Carlton Gibson:

Yes, thanks for the report. I'm seeing this only for the Choose arrow, and not for Remove.

​PR.

This pr changed .active.selector-remove:focus, .active.selector-remove:hover and .active.selector-add:focus, .active.selector-add:hover

comment:5 by Carlton Gibson, 5 years ago

Thanks for the extra screenshots. Yes, the hover state for the remove arrow should have the highlight. (I was looking for the misplacement.)

comment:6 by Carlton Gibson, 5 years ago

Patch needs improvement: set

comment:7 by Carlton Gibson, 5 years ago

Triage Stage: Accepted → Ready for checkin

comment:8 by Carlton Gibson, 5 years ago

Patch needs improvement: unset

comment:9 by Carlton Gibson <carlton@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In a4881f5e:

Fixed #31307 -- Fixed filter_horizontal add/remove SVG :hover positioning.

comment:10 by 007, 5 years ago

This problem also occurs in 2.2 and 3.0. What do I need to do to merge the changes into stable/2.2.x and stable/3.0.x

comment:11 by Mariusz Felisiak, 5 years ago

This patch doesn't qualify for a backport per our backporting policy, see ​https://docs.djangoproject.com/en/3.0/internals/release-process/ for more details.

Note: See TracTickets for help on using tickets.
Back to Top