Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31226 closed Cleanup/optimization (fixed)

Typo in "Submitting patches" docs.

Reported by: Vibhu Agarwal Owned by: Vibhu Agarwal
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Documentation Link: ​https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#deprecating-a-feature

Under Deprecating a feature: First Line
"There are a couple reasons that code in Django might be deprecated:"

Problem: Missing preposition

Attachments (1)

django_doc_typo_ss.png​ (141.9 KB ) - added by Vibhu Agarwal 5 years ago.

Download all attachments as: .zip

Change History (8)

by Vibhu Agarwal, 5 years ago

Attachment: django_doc_typo_ss.png​ added

comment:1 by Vibhu Agarwal, 5 years ago

Owner: changed from nobody to Vibhu Agarwal
Status: new → assigned

comment:2 by Vibhu Agarwal, 5 years ago

Has patch: set

comment:3 by Mariusz Felisiak, 5 years ago

Triage Stage: Unreviewed → Accepted

​PR

comment:4 by GitHub <noreply@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In 6f9ecc2:

Fixed #31226 -- Fixed typo in docs/internals/contributing/writing-code/submitting-patches.txt.

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In 0bf1330:

[3.0.x] Fixed #31226 -- Fixed typo in docs/internals/contributing/writing-code/submitting-patches.txt.

Backport of 6f9ecc23f676e7a6f25d1a6cf830fe638a1eb589 from master

comment:6 by Adam Johnson, 5 years ago

FWIW "a couple reasons" is an Americanism, so this wouldn't be considered as missing a preposition in en-US

comment:7 by Mariusz Felisiak, 5 years ago

I had a gut feeling that it's an Americanism :)

Note: See TracTickets for help on using tickets.
Back to Top