Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#3118 closed defect (fixed)

[patch] errata in UPDATE/INSERT section in DB-API document

Reported by: makoto tsuyuki <mtsuyuki@…> Owned by: Jacob
Component: Documentation Version: dev
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Isn't this opposite?

django/doc/db-api.txt

line 145

  • If the object's primary key attribute is set to a value that evaluates to False (such as None or the empty string), Django executes a SELECT query to determine whether a record with the given primary key already exists.

Attachments (2)

fixing_dbapi_doc_erratta.txt (995 bytes ) - added by ymasuda <ymasuda@…> 18 years ago.
Fixing errata on db-api.txt documentation.
fixing_dbapi_doc_erratta.diff (995 bytes ) - added by ymasuda <ymasuda@…> 18 years ago.
Fixing errata on db-api.txt documentation (file extension was corrected to .diff sorry for noise).

Download all attachments as: .zip

Change History (8)

comment:1 by ymasuda <ymasuda@…>, 18 years ago

According to a codepath and comment on http://code.djangoproject.com/browser/django/trunk/django/db/models/base.py, lines 172-212,
This should be corrected such as "If the object's primary key attribute is set to a value that evaluates to True (whatever excluding None or empty string), Django executes a ...".
I'll post a patch soon.

by ymasuda <ymasuda@…>, 18 years ago

Fixing errata on db-api.txt documentation.

comment:2 by ymasuda <ymasuda@…>, 18 years ago

Summary: DB-API document has description bug.[patch] DB-API document has description bug.

comment:3 by ymasuda <ymasuda@…>, 18 years ago

Summary: [patch] DB-API document has description bug.[patch] errata in UPDATE/INSERT section in DB-API document

by ymasuda <ymasuda@…>, 18 years ago

Fixing errata on db-api.txt documentation (file extension was corrected to .diff sorry for noise).

comment:4 by Russell Keith-Magee, 18 years ago

Resolution: fixed
Status: newclosed

(In [4221]) Fixed #3118 -- Fixed reversed logic in DBAPI regarding handling of empty PKs on save(). Thanks, Makoto Tsuyuki.

comment:5 by Russell Keith-Magee, 18 years ago

(In [4222]) Refs #3118 -- Forgot to mention the efforts of Yashudi Masuda in triaging #3118, committed as [4221]. Thanks!

comment:6 by Russell Keith-Magee, 18 years ago

That should be Yasushi Masuda. Apologies for getting your name wrong in the commit message.

Note: See TracTickets for help on using tickets.
Back to Top