Opened 5 years ago

Closed 5 years ago

#31042 closed Cleanup/optimization (fixed)

Rewrite AdminSeleniumTestCase.get_css_value() without jQuery.

Reported by: Jon Dufresne Owned by: Jon Dufresne
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

jQuery is used in AdminSeleniumTestCase.get_css_value() to query an element by a CSS selector and then return a CSS property.

Both of these operations have equivalent native Browser support and so this method does not require jQuery.

jQuery() → document.querySelector()
.css() → HTMLElement.style

Change History (3)

comment:2 by Mariusz Felisiak, 5 years ago

Owner: changed from nobody to Jon Dufresne
Status: new → assigned
Triage Stage: Unreviewed → Accepted

comment:3 by Carlton Gibson <carlton.gibson@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In c8bd37a8:

Fixed #31042 -- Removed AdminSeleniumTestCase.get_css_value() in favor of Selenium .is_displayed().

All instances of AdminSeleniumTestCase.get_css_value() were used to
inspect the display property.

Note: See TracTickets for help on using tickets.
Back to Top