#3080 closed defect (fixed)
[bug] delete_cookie method imporoperly sets the domain parameter in django/http/!__init!__.py
| Reported by: | nowell strite | Owned by: | Adrian Holovaty |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In django/http/__init__.py the delete_cookie method improperly sets the domain parameter to the path parameter. Below is a patch that corrects the oversight.
Index: django/http/__init__.py
===================================================================
--- django/http/__init__.py (revision 4126)
+++ django/http/__init__.py (working copy)
@@ -208,7 +208,7 @@
if path is not None:
self.cookies[key]['path'] = path
if domain is not None:
- self.cookies[key]['domain'] = path
+ self.cookies[key]['domain'] = domain
self.cookies[key]['expires'] = 0
self.cookies[key]['max-age'] = 0
Note:
See TracTickets
for help on using tickets.
(In [4135]) Fixed #3080 -- Fixed bug in delete_cookie() method. Thanks, nowell strite