Opened 5 years ago
Closed 5 years ago
#30779 closed Cleanup/optimization (fixed)
technical_500.html: use filename:lineno format for exception location
| Reported by: | Daniel Hahler | Owned by: | |
|---|---|---|---|
| Component: | Error reporting | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Hasan Ramezani | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Using
Exception Location: …/dj/views.py, line 28, in form_valid
instead of
Exception Location: …/dj/views.py in form_valid, line 28
would allow for easier copy'n'paste of the location for going there in an editor.
The format fname:lnum is usually handled there to go to the line number there directly.
By default this does not work as good as it could then, since browsers will not include the ":" on double-click (tested Firefox and qutebrowser), but the "text-select" CSS property can be used for this, which then selected it with a single click already. Ref: https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
Change History (6)
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|---|
| Has patch: | set |
| Patch needs improvement: | set |
comment:2 by , 5 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 5 years ago
Thanks Carlton.
Please see https://github.com/django/django/pull/11789 then.
It probably only needs test adjustments, which I'd like to do only in the end.
comment:4 by , 5 years ago
| Cc: | added |
|---|---|
| Patch needs improvement: | unset |
comment:5 by , 5 years ago
| Description: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.
Hey Daniel. Yes, sounds like a nice gain. I am certainly happy to review a PR on it. :) Thanks.