Opened 18 years ago

Closed 18 years ago

#3071 closed defect (fixed)

[patch] Context should have the __contains__ method

Reported by: Antti Kaihola Owned by: Adrian Holovaty
Component: Template system Version:
Severity: normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The Context class in django.template.context should have a __contains__ method defined, so that one can do:

if 'missiles' not in context:
    raise ImproperlyConfigured, \
        'Please include missiles in the context so we can destroy the world.'
    destroy_world_with(context['missiles'])

Although, the destroy_world_with function is left as an exercise for the reader.

A simple patch which concerns context.py is included.

Attachments (1)

context_contains.diff (422 bytes ) - added by Antti Kaihola 18 years ago.
Adds the contains method for Context

Download all attachments as: .zip

Change History (5)

by Antti Kaihola, 18 years ago

Attachment: context_contains.diff added

Adds the contains method for Context

comment:1 by Chris Beaven, 18 years ago

Summary: Context should have the __contains__ method[patch] Context should have the __contains__ method

comment:2 by Adrian Holovaty, 18 years ago

Component: Core frameworkTemplate system

comment:3 by Simon G. <dev@…>, 18 years ago

Triage Stage: UnreviewedReady for checkin

comment:4 by Malcolm Tredinnick, 18 years ago

Resolution: fixed
Status: newclosed

(In [4480]) Fixed #3071 -- added a __contains__ method to the Context class. Thanks
akaihola.

Note: See TracTickets for help on using tickets.
Back to Top