Opened 5 years ago

Closed 5 years ago

#30392 closed Cleanup/optimization (needsinfo)

Onboarding new contibutors improvements

Reported by: Chris Wedgwood Owned by: nobody
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Chris Wedgwood)

I have just gone through the onboarding process for contributing to django on windows and
noticed one thing that could be improved

In https://github.com/django/django/blob/master/docs/intro/contributing.txt#L208 Change runtest.py to python runtest.py for windows users
as when I ran it first time it just opened in vscode and didnt run.

Change History (3)

comment:1 by Chris Wedgwood, 5 years ago

Description: modified (diff)

comment:2 by Chris Wedgwood, 5 years ago

Version: 2.2master

comment:3 by Carlton Gibson, 5 years ago

Resolution: needsinfo
Status: newclosed

Hi Chris.

I'm going to say this needs info currently. I'm not sure why you're seeing the behaviour you are but, on Windows I just type runtests.py (Well I type run and tab for completion) and it runs the test suite, rather than opening the file. Thus we need to pin down what's different in your case.

Take a look at 25b5eea8cdc69a353bb2d22ea2012b09df6c62e4, added just a couple of days ago. Does this help?

Happy to look at specific suggestions for changes, in a PR say, but not sure that the particular change you're suggesting here is (yet) quite right.

Thanks!

Note: See TracTickets for help on using tickets.
Back to Top