object.save() doesn't update, re-inserts

[Manuzhai]

Probably something to do with [462]. My model:

class Post(meta.Model):
    fields = (
        meta.MZSlugField('slug', 'slug', prepopulate_from = ('title',)),
        meta.CharField('title', 'title', maxlength = 255),
        meta.DateTimeField('datetime', 'date created'),
        meta.DateTimeField('modified', 'date modified'),
        meta.TextField('content', 'post'),
        meta.ManyToManyField(Tag, filter_interface = meta.HORIZONTAL),
    )
    admin = meta.Admin(
        fields = (
            (None, {'fields': ('title', 'slug', 'datetime', 'content', 'tags')}$
        ),
        list_display = ('title', 'datetime', 'display_tags'),
        list_filter = ('datetime', 'tags'),
    )
    ordering = ('-datetime',)
    def __repr__(self):
        return self.title
    def display_tags(self):
        return ' '.join([obj.tag for obj in self.get_tag_list()])
    display_tags.short_description = 'Tags'

I'm doing this with the API, from the interactive interpreter.

[Adrian Holovaty]

Could you paste in the API code you used to save? Our unit tests are passing, so I suspect your API calls might be strange.

[Manuzhai]

Was really basic, something like this:

>>> from django.models.posts import posts, tags
>>> mv = tags.get_object(tag__exact = 'movies')
>>> post = posts.get_object(slug__exact = 'you-stupid-man')
>>> post.set_tags([mv.id])
>>> post.save()
>>> post.save()

This is with [473].

[Jacob]

Why are you calling save() twice?

[Manuzhai]

That was to test that it was inserting another time. That shouldn't re-insert the object, though, should it?

[Adrian Holovaty]

You don't need to call post.save() after calling post.set_tags().

You only need post.save() to save fields on the object itself. It has no effect on related objects.

[Manuzhai]

Okay, that actually makes sense. But still, why is it re-inserting?

[Boffbowsh]

I'm getting a similar problem with the admin interface. If nothing has changed and then you hit save, it tries to reinsert, but fails as my primary key isn't an autofield

class Player (meta.Model):
	fields = (
		meta.IntegerField('profileid', primary_key=True),
		meta.CharField('realname', maxlength=32, blank=True),
		meta.IntegerField('bookingid'),
		meta.CharField('ingamename', maxlength=32, db_index=True, unique=True),
		meta.ForeignKey(Team, blank=True),
		meta.ForeignKey(Server, name="lastseenon")
	)

	def __repr__(self):
		return self.ingamename
	
	admin = meta.Admin(
			search_fields = ['ingamename', 'profileid'],
		)

[Manuzhai]

I think this is probably fixed as a result of [507], see also #320.

[Adrian Holovaty]

Good call, Manuzhai. This should be fixed now.