Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#30102 closed Cleanup/optimization (wontfix)

Optimize the `page_not_found` view after #30070

Reported by: Illia Volochii Owned by: nobody
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is no need to use the template system here.
The content has not got variables and can be just a byte string.

Change History (3)

comment:1 by Illia Volochii, 6 years ago

Summary: Optimize the `page_not_found` after #30070Optimize the `page_not_found` view after #30070

comment:2 by Carlton Gibson, 6 years ago

Resolution: wontfix
Status: newclosed

As per discussion on the original PR, there are test cases relying on the template context being available on the response. Working around this probably isn't worth the effort. Follow-up PR adds a comment explaining the usage, as per Tim's suggestion.

comment:3 by GitHub <noreply@…>, 6 years ago

In 876dc30:

Refs #30102 -- Added comment on use of Template without placeholders in page_not_found() view.

Note: See TracTickets for help on using tickets.
Back to Top