Opened 6 years ago

Closed 6 years ago

#29763 closed Cleanup/optimization (fixed)

Add support for column renames on SQLite3 in schema editor

Reported by: Markus Holtermann Owned by: Hampus Dunström
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Starting with version 3.25.0, SQLite3 gained support for ALTER TABLE table RENAME COLUMN oldname TO newname: ​https://www.sqlite.org/releaselog/3_25_0.html

The SQLite3 schema editor, used by the migrations framework, however, won't use this new feature yet, but instead will continue to create a new table and copy data over.

This ticket is about evaluating the feasibility of adding RENAME COLUMN support for column renames on SQLite3 >=3.25 while keeping the "remake table" approach for older versions.

One thing we need to ensure, we _somehow_ need to keep testing the old and new behavior on our CI.

Change History (5)

comment:1 by Tim Graham, 6 years ago

Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

comment:2 by Hampus Dunström, 6 years ago

Owner: changed from nobody to Hampus Dunström
Status: new → assigned

comment:3 by Hampus Dunström, 6 years ago

​PR

comment:4 by Hampus Dunström, 6 years ago

Has patch: set

comment:5 by Tim Graham <timograham@…>, 6 years ago

Resolution: → fixed
Status: assigned → closed

In 5e8a07d6:

Fixed #29763 -- Added support for column renaming on SQLite.

Note: See TracTickets for help on using tickets.
Back to Top