Auto population doesn't work for multiple slugs on the same model

[Archatas <aidas.bendoraitis at gmail>]

If there is a model with more than one SlugField, then the javascript for automatic slug population is generated only for the last slug field of the model in the contributed administration.

The problem is simple and fixable in minutes.
The template tag auto_populated_field_script in django/contrib/admin/templatetags/admin_modify.py overwrites the previously collected javascript within every new iteration:

def auto_populated_field_script(auto_pop_fields, change = False):
    for field in auto_pop_fields:
         t = []
         ...
    return ''.join(t)

What has to be changed is that the t list has to be defined before iteration start:

def auto_populated_field_script(auto_pop_fields, change = False):
    t = []
    for field in auto_pop_fields:
         ...
    return ''.join(t)

[Jacob]

(In [4034]) Fixed #2972: prepopulate_from now works with multiple slugs on the same field. Thanks, Archatas.

[panta@…]

auto_populated_field_script patch for multiple slugs in a model

[panta@…]

In my case (r6373, konqueror on linux) it doesn't work.
I've attached a patch that solves the problem (tested both with konqueror and Firefox).
Cheers,
Marco

[Jacob]

I can't reproduce this, but it worksforme in Gecko/WebKit/IE, so I'm going to assume if there's a bug it's with Konqueror.

[anonymous]

Replying to jacob:

I can't reproduce this, but it worksforme in Gecko/WebKit/IE, so I'm going to assume if there's a bug it's with Konqueror.

I am no js expert, and I can't say if it's a bug with konqueror or django, but the patch is super-simple, and many users use konqueror, so why not simply integrate the patch and make everyone happy?