Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#29523 closed Cleanup/optimization (fixed)

Remove DateTimeShortcuts.js dependency on jQuery

Reported by: Claude Paroz Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

DateTimeShortcuts.js is only marginally depending on jQuery, so I think a pure JavaScript implementation would be trivial to achieve.

Change History (7)

comment:1 by Mariusz Felisiak, 6 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Claude Paroz, 6 years ago

There is a ​PR already, albeit with test failures.

comment:4 by Tim Graham, 6 years ago

Has patch: set
Patch needs improvement: set

comment:5 by Claude Paroz, 6 years ago

Patch needs improvement: unset

comment:6 by Tim Graham <timograham@…>, 6 years ago

Resolution: → fixed
Status: new → closed

In ba83378a:

Fixed #29523 -- Removed jQuery usage in DateTimeShortcuts.js & collapse.js.

comment:7 by Tim Graham <timograham@…>, 6 years ago

In 93e892bb:

Refs #29523 -- Updated admin's collapse.min.js.

Omitted in ba83378a7762c51be235b521aa5b48233d6c6c82.

comment:8 by Tim Graham <timograham@…>, 6 years ago

In d29c8ea1:

[2.2.x] Refs #29523 -- Updated admin's collapse.min.js.

Omitted in ba83378a7762c51be235b521aa5b48233d6c6c82.

Backport of 93e892bb645b16ebaf287beb5fe7f3ffe8d10408 from master.

Note: See TracTickets for help on using tickets.
Back to Top