Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#2940 closed defect (fixed)

[patch] settings.MANAGERS does not default to settings.ADMINS

Reported by: matt.riggott@… Owned by: Jacob
Component: Documentation Version: dev
Severity: minor Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The settings documentation notes that MANAGERS defaults to ADMINS. Alas, this isn't true.

So what actually happens? Well, in django.conf.global_settings, MANAGERS is set to equal ADMINS — an empty tuple. But when ADMINS is set in a project's settings file MANAGERS remains an empty tuple.

There are two solutions. The first, and by far simplest, is to change the documentation to note that MANAGERS defaults to an empty tuple. The second is to modify the code in django.conf to make a special case of MANAGERS (and perhaps other settings) so that it is changed to equal the project's settings.ADMINS if empty. I'll attach the first solution as a patch.

That wasn't the easiest thing to explain, but I hope it makes sense.

Attachments (1)

settings.txt.diff (424 bytes ) - added by matt.riggott@… 18 years ago.
Patch to make a minor change to the documentation on settings.MANAGERS

Download all attachments as: .zip

Change History (4)

by matt.riggott@…, 18 years ago

Attachment: settings.txt.diff added

Patch to make a minor change to the documentation on settings.MANAGERS

comment:1 by anonymous, 18 years ago

Summary: settings.MANAGERS does not default to settings.ADMINS[patch] settings.MANAGERS does not default to settings.ADMINS

comment:2 by Adrian Holovaty, 18 years ago

Resolution: fixed
Status: newclosed

Fixed in [3923].

comment:3 by (none), 18 years ago

milestone: Version 1.0

Milestone Version 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top