Opened 7 years ago
Closed 7 years ago
#29390 closed Bug (wontfix)
trans_null.ngettext() should consider values of -1 as singular
Reported by: | Hasan Ramezani | Owned by: | Hasan Ramezani |
---|---|---|---|
Component: | Internationalization | Version: | 2.0 |
Severity: | Normal | Keywords: | |
Cc: | Carlton Gibson | Triage Stage: | Unreviewed |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
This is the English convention.
Change History (4)
comment:1 by , 7 years ago
Has patch: | set |
---|---|
Owner: | changed from | to
Status: | new → assigned |
comment:2 by , 7 years ago
comment:3 by , 7 years ago
Description: | modified (diff) |
---|---|
Summary: | ngettext function bug in trans_null.py → trans_null.ngettext() should consider values of -1 as singular |
I don't know. Whether or not -1 is considered singular seems to dependent on the context.
comment:4 by , 7 years ago
Cc: | added |
---|---|
Resolution: | → wontfix |
Status: | assigned → closed |
Hi Hasan. Thanks for the input.
I'm inclined towards wontfix
here. A couple of reasons:
- As per Tim's point, I'm not at all convinced that
-1
is definitely singular. (Like "maybe" but I can't say either is wrong.) - As Simon commented on the PR it breaks BC, and (per above) it's marginal at best, so not worth it.
I'm going to close on that basis. If someone wants to make the case and re-open, I guess I'm happy to look again.
Note:
See TracTickets
for help on using tickets.
PR https://github.com/django/django/pull/9932