Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#29375 closed Cleanup/optimization (fixed)

Remove empty form action attribute

Reported by: CHI Cheng Owned by: nobody
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

According to the ​stackoverflow discussion, action="" can be omitted from most <form> tags in docs.

If it's accepted, I'll create a pull request based on this commit: ​https://github.com/chicheng/django/commit/d1d3658eef1e435c08ac1d6a67793f6c3d9e6f1a

Change History (4)

comment:1 by Claude Paroz, 7 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by CHI Cheng, 7 years ago

Pull request: ​https://github.com/django/django/pull/9914

One build failed: ​https://djangoci.com/job/pull-requests-trusty/database=postgres,label=trusty-pr,python=python3.6/18012/console

 File "/home/jenkins/workspace/pull-requests-trusty/database/postgres/label/trusty-pr/python/python3.6/django/core/cache/backends/memcached.py", line 154, in __init__
    import memcache
ModuleNotFoundError: No module named 'memcache'
Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
Finished: FAILURE

comment:3 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: new → closed

In 4660ce5a:

Fixed #29375 -- Removed empty action attribute on HTML forms.

comment:4 by Tim Graham <timograham@…>, 7 years ago

In 482ba924:

[2.0.x] Fixed #29375 -- Removed empty action attribute on HTML forms.

Backport of 4660ce5a6930e07899ed083801845ee4c44c09df from master

Note: See TracTickets for help on using tickets.
Back to Top