Opened 6 years ago

Closed 6 years ago

#29288 closed Bug (fixed)

{% widthratio %} fails to assign to variable if exception happens

Reported by: Jirka Vejrazka Owned by: nobody
Component: Template system Version: dev
Severity: Normal Keywords: templatetag, widthratio
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Jirka Vejrazka)

When an exception happens inside the widthratio template tag, the result is returned as a string instead of being assigned to a variable even if as variable is used in the template tag.

Change History (4)

comment:2 by Jirka Vejrazka, 6 years ago

Description: modified (diff)
Summary: {% widthratio %} fails to assign to variable on exceptions → {% widthratio %} fails to assign to variable if exception happens

comment:3 by Carlton Gibson, 6 years ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

Issue seems reasonable. Test cases fail without patch. I just had a couple of comments on the PR.

comment:4 by Tim Graham <timograham@…>, 6 years ago

Resolution: → fixed
Status: new → closed

In 6148dda7:

Fixed #29288 -- Made {% widthratio %} assign to as var if an exception occurs.

Note: See TracTickets for help on using tickets.
Back to Top