[patch] FileField does not allow modifications on Windows

[radek]

When you have FileField (or ImageField) and use Django on Windows, second time uploaded filename is always considered invalid.
Ie. you can create one instance, but you can't go back and edit this one and save. You always get:

Enter a valid filename.

The issue is in

\django\trunk\django\db\models\fields\init.py on line 579

Because
os.path.abspath(os.path.join(settings.MEDIA_ROOT, field_data)):

will give:
'D:
www
myproject
media
subfolder
1-icon.png'

while this
os.path.normpath(settings.MEDIA_ROOT):

gives:

'
www
myproject
media'

You can see missing Drive name.

Patch is here:

@@ -576,7 +576,7 @@
         # If the raw path is passed in, validate it's under the MEDIA_ROOT.
         def isWithinMediaRoot(field_data, all_data):
             f = os.path.abspath(os.path.join(settings.MEDIA_ROOT, field_data))
-            if not f.startswith(os.path.normpath(settings.MEDIA_ROOT)):
+            if not f.startswith(os.path.abspath(os.path.normpath(settings.MEDIA_ROOT))):
                 raise validators.ValidationError, _("Enter a valid filename.")
         field_list[1].validator_list.append(isWithinMediaRoot)
         return field_list

Pitty I spent a whole day, before I found it.

[Chris Beaven]

Just marking that this contains a patch.

[Chris Beaven]

Just confirming the fix since it's unusual that tickets are closed by anonymous.

This was fixed in [4036].

[(none)]

Milestone Version 1.0 deleted

[justin.driscoll@…]

The current patch did not solve what seems to be the same problem for me. A forward slash appended to the beginning "field_data" was causing "os.path.abspath(os.path.join(settings.MEDIA_ROOT, field_data))" to return an incorrect path and raise a validation error.

[justin.driscoll@…]

Strip forward slash from "field_data" in "isWithinMediaRoot".

[Malcolm Tredinnick]

Justin, please open a new ticket with your problem and an explanation of how to repeat it. That will help use keep comments on the new change separate from the history for this ticket.