Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#29221 closed Bug (fixed)

No space added before admin-autocomplete CSS class

Reported by: Artem Tabolin Owned by: nobody
Component: contrib.admin Version: 2.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

When Django adds admin-autocomplete CSS class to the select widget, it doesn't add a space before resulting in two concatenated CSS class names.

One of the consequences: autocomplete doesn't work if initial class attribute wasn't empty.

The operation is performed here:​https://github.com/django/django/blob/e17088a108e604cad23b000a83189fdd02a8a2f9/django/contrib/admin/widgets.py#L416

Change History (4)

comment:2 by Tim Graham, 7 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin

comment:3 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: new → closed

In a2f7433:

Fixed #29221 -- Corrected admin's autocomplete widget to add a space after custom classes.

comment:4 by Tim Graham <timograham@…>, 7 years ago

In 9bf8664b:

[2.0.x] Fixed #29221 -- Corrected admin's autocomplete widget to add a space after custom classes.

Backport of a2f7433adc610cb0a85b3e23a1fec2267591f866 from master

Note: See TracTickets for help on using tickets.
Back to Top