Changes between Initial Version and Version 2 of Ticket #29048


Ignore:
Timestamp:
Jan 24, 2018, 2:37:55 PM (7 years ago)
Author:
Matthew Pava
Comment:

I updated the description to describe the problem in better detail.

When I was working on ​PR 9583, a contributor made this comment when I had unintentionally made the changes to other classes not related to that PR:

I've also noticed a warning in Pycharm that the signature of as_sqlite and as_oracle doesn't match the superclass. I'd guess it's better to deal with this in a different PR.

I assumed that the contributor was speaking on behalf of "other developers."

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #29048

    • Property Easy pickings unset

  • Ticket #29048 – Description

    initial v2  
    1 `Func` inherits from `SQLiteNumericMixin`, which added an extra argument to `as_sqlite`: `**extra_context`.  Based on feedback from other developers, it seems we should add this argument to each `as_vendor` method.
     1`Func` inherits from `SQLiteNumericMixin`, which added an extra argument to `as_sqlite`: `**extra_context`.  PyCharm flags the database functions that inherit from `Func` because their `as_sqlite` methods do not have that extra argument.
     2
Back to Top