Opened 7 years ago
Closed 6 years ago
#29048 closed Cleanup/optimization (fixed)
Add **extra_context arg to as_vendor methods in database functions
| Reported by: | Matthew Pava | Owned by: | Priyansh Saxena |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Func inherits from SQLiteNumericMixin, which added an extra argument to as_sqlite: **extra_context. PyCharm flags the database functions that inherit from Func because their as_sqlite methods do not have that extra argument.
Change History (8)
comment:1 by , 7 years ago
| Easy pickings: | unset |
|---|
comment:2 by , 7 years ago
| Description: | modified (diff) |
|---|
I updated the description to describe the problem in better detail.
When I was working on PR 9583, a contributor made this comment when I had unintentionally made the changes to other classes not related to that PR:
I've also noticed a warning in Pycharm that the signature of as_sqlite and as_oracle doesn't match the superclass. I'd guess it's better to deal with this in a different PR.
I assumed that the contributor was speaking on behalf of "other developers."
comment:3 by , 7 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
But there's no concrete issue, correct? I suppose we can change those signatures, even if it's just fix the PyCharm warnings.
comment:5 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:7 by , 7 years ago
| Patch needs improvement: | set |
|---|
Is there a concrete problem? It's unclear what "Based on feedback from other developers" refers to.