Opened 7 years ago
Closed 7 years ago
#28930 closed Cleanup/optimization (fixed)
Simplify code with all() and any()
| Reported by: | Дилян Палаузов | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Attachments (1)
Change History (12)
by , 7 years ago
| Attachment: | any_all.patch added |
|---|
comment:1 by , 7 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 7 years ago
| Description: | modified (diff) |
|---|
What is the policy for taking this patch and raising a PR? Ofcourse, I acknowledge the author.
I like this patch very much, i couldn't resist to raise a PR. If i break the unspoken rules, please close the PR.
comment:4 by , 7 years ago
| Component: | Uncategorized → Core (Other) |
|---|---|
| Has patch: | set |
| Summary: | Utilize all()/any() → Simplify code iwth all() and any() |
| Triage Stage: | Accepted → Ready for checkin |
That's fine. For future reference, the way to credit the patch author is using git commit --amend --author="Дилян Палаузов <Dilyan.Palauzov@db.com>". It would have been nice if you fixed up the flake8 issues and the failing lists, but I've done that. I also reverted changes to vendored code like six.py and an incorrect change in admin/utils.py which changed behavior and broke a test.
comment:5 by , 7 years ago
| Summary: | Simplify code iwth all() and any() → Simplify code with all() and any() |
|---|
comment:7 by , 7 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → new |
What happened to the changes in django/utils/translation/trans_real.py and tests/schema/tests.py ?
comment:9 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Changes were made to django/utils/translation/trans_real.py in the original patch.
comment:10 by , 7 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → new |
I wrote django/utils/translation/trans_real.py but I meant django/utils/http.py .
comment:11 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
As the docstring indicates, that code is copied from cpython so I didn't want to make substantial changes to it.
Thanks, please provide a pull request.