#28885 closed Bug (fixed)
Bottom parts of "Congratulations!" page cut off internationalized content
| Reported by: | Maciej Olko | Owned by: | Himanshu Chauhan |
|---|---|---|---|
| Component: | Core (Other) | Version: | 2.0 |
| Severity: | Normal | Keywords: | i18n, template, defaults |
| Cc: | Timothy Allen | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | yes |
Description (last modified by )
Bottom parts (footer) of "Congratulations!" page[1] (rocket taking off/default urlconf) cut off text if it is too long. It happens for e.g. Russian and Lower Serbian languages. Screenshots:
For many other languages, the problem is more of just esthetic nature, as the padding to the bottom of page is not equal to padding to the footer top ruler (if translations aren't one-liners in effect).
The footer shouldn't have fixed height. I am afraid that some JavaScript is neccessary to calculate footer's height if we are about to keep the layout.
[1] django/django/views/templates/default_urlconf.html
Change History (11)
comment:1 by , 7 years ago
| Cc: | added |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 7 years ago
| Description: | modified (diff) |
|---|
You can also test it with official Django translations, by just changing the LANGUAGE_CODE setting. Language codes that have longest translations (AFAIK) are "ru" and "dsb".
follow-up: 5 comment:4 by , 7 years ago
I have tweaked the CSS of the web page so that it does not change original design and fix the mentioned bug. Can I claim this ticket and submit the patch?
comment:5 by , 7 years ago
Replying to Himanshu Chauhan:
I have tweaked the CSS of the web page so that it does not change original design and fix the mentioned bug. Can I claim this ticket and submit the patch?
Absolutely! My colleague and I were working on a fix, but if you've got something complete, by all means take the ticket and issue a P.R. Thanks so much!
comment:6 by , 7 years ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
comment:7 by , 7 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:9 by , 7 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
The patch looks good. (Screenshots on PR)
The commit message does not quite match the guidelines, but could be adjusted when merging.
Need to confirm Himanshu submitted the CLA.
Update: both these queries addressed in PR https://github.com/django/django/pull/9570#issuecomment-356871766
We will tweak the design so it works in more languages, and test with Google Translate. Thanks for the catch!