Autocomplete select for new lines in inline model do not open

[Marcus Götling]

When a model has an Inline model, autocomplete select does not show for new rows.

Select box is is replaced with Select2 style, but clicking it does not show the select list.

model.py

class Item(models.Model):
    name = models.CharField(max_length=100)

class Category(models.Model):
    name = models.CharField(max_length=100)

    def __str__(self):
        return self.name

class LineItem(models.Model):
    item = models.ForeignKey(
        'Item',
        on_delete=models.CASCADE
    )
    category = models.ForeignKey(
        'Category',
        on_delete=models.CASCADE
    )

admin.py

class LineItemInline(admin.TabularInline):
    model = LineItem
    extra = 1

    autocomplete_fields = ('category',)

@admin.register(Item)
class ItemAdmin(admin.ModelAdmin):
    list_display = ('name',)
    search_fields = ('name',)

    inlines = [
        LineItemInline
    ]

@admin.register(Category)
class CategoryAdmin(admin.ModelAdmin):
    list_display = ('name',)
    search_fields = ('name',)

Github repo

With demo and instructions on how to reproduce

​https://github.com/gotling/bug-django2-autocomplete

[Marcus Götling]

Inline

[Claude Paroz]

I was able to reproduce, but only for new forms added by clicking on the "Add another ..." link.

[Johannes Maron]

Might I just say: This is an amazing bug report! I'll look into it this weekend, thanks :)

[Tim Graham]

The Django 2.0 release is scheduled for today so maybe me or somebody else would look at the issue if you don't have time today.

[Tim Graham]

I found that this patch will allow the "Add another" autocomplete widgets to work, except for the first one that's added.

django/contrib/admin/static/admin/js/autocomplete.js

@@ -29 +29 @@
 
     $(document).on('formset:added', (function() {
         return function(event, $newFormset) {
-            var $widget = $newFormset.find('.admin-autocomplete');
-            // Exclude already initialized Select2 inputs.
-            $widget = $widget.not('.select2-hidden-accessible');
-            return init($widget);
+            return $newFormset.find('.admin-autocomplete').djangoAdminSelect2()
         };
     })(this));
 }(django.jQuery));

It looks like the contents of $newFormset for the first "add another" is different from the contents of subsequent "add anothers".

[Tim Graham]

I think a have a working patch and am writing a test.

[Tim Graham]

​PR

[Tim Graham <timograham@…>]

In 81057645:

Fixed #28871 -- Fixed initialization of autocomplete widgets in "Add another" inlines.

Also allowed autocomplete widgets to work on AdminSites with a name other
than 'admin'.

[Tim Graham <timograham@…>]

In 63d425c6:

[2.0.x] Fixed #28871 -- Fixed initialization of autocomplete widgets in "Add another" inlines.

Also allowed autocomplete widgets to work on AdminSites with a name other
than 'admin'.

Backport of 81057645f61fe545f4f11737dbd3040043ed2436 from master

[Tim Graham <timograham@…>]

In 7664fe2:

Refs #28871 -- Fixed admin_views selenium test failure.

[Tim Graham <timograham@…>]

In dbdf5dea:

[2.0.x] Refs #28871 -- Fixed admin_views selenium test failure.

Backport of 7664fe275910bb31fcca2d54844bedde19fc4ed9 from master