Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#28837 closed Bug (fixed)

test client crashes if an exception with more than one argument is raised

Reported by: Nicolas Delaby Owned by: nobody
Component: Testing framework Version: 2.0
Severity: Release blocker Keywords:
Cc: Nicolas Delaby, Claude Paroz Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In case the exception instance accept more than one positional parameter to instantiate, the test client is failing to re-raise it.

Change History (12)

comment:1 by Nicolas Delaby, 7 years ago

Cc: Nicolas Delaby added

comment:2 by Nicolas Delaby, 7 years ago

Summary: test client failed to expose Exceptions that requires more than one positional parametertest client fail to expose Exceptions that require more than one positional parameter

comment:3 by Nicolas Delaby, 7 years ago

Type: UncategorizedBug

comment:4 by Simon Charette, 7 years ago

Cc: Claude Paroz added
Triage Stage: UnreviewedAccepted

Regression introduced by 6e55e1d88a5c4453e25f0caf7ffb68973de5c0ba (refs #23919). It looks like there might be other instances that require adjustments

Do you think you could handle these as well? Also it looks like there's a lot of boilerplate involved to perform the re-reraise. Claude, do you have a better idea of how these should be handled?

comment:5 by Simon Charette, 7 years ago

comment:6 by Nicolas Delaby, 7 years ago

I will look into it. and probably create an helper function.

comment:7 by Tim Graham, 7 years ago

Easy pickings: unset
Patch needs improvement: set

comment:8 by Claude Paroz, 7 years ago

I think we should evaluate if simply replacing raise exc_info[0](exc_info[1]).with_traceback(exc_info[2]) by raise exc_info[1].with_traceback(exc_info[2]) would make it.

comment:9 by Tim Graham, 7 years ago

Patch needs improvement: unset
Summary: test client fail to expose Exceptions that require more than one positional parametertest client crashes if an exception with more than one argument is raised

I've updated the PR based on the discussion there.

comment:10 by Simon Charette, 7 years ago

Triage Stage: AcceptedReady for checkin

comment:11 by Tim Graham <timograham@…>, 7 years ago

Resolution: fixed
Status: newclosed

In 746caf3e:

Fixed #28837 -- Fixed test client crash if an exception with more than one arg is raised.

Also removed usage of the problematic pattern elsewhere.

Regression in 6e55e1d88a5c4453e25f0caf7ffb68973de5c0ba.

comment:12 by Tim Graham <timograham@…>, 7 years ago

In ae4132a9:

[2.0.x] Fixed #28837 -- Fixed test client crash if an exception with more than one arg is raised.

Also removed usage of the problematic pattern elsewhere.

Regression in 6e55e1d88a5c4453e25f0caf7ffb68973de5c0ba.

Backport of 746caf3ef821dbf7588797cb2600fa81b9df9d1d from master

Note: See TracTickets for help on using tickets.
Back to Top