#28837 closed Bug (fixed)
test client crashes if an exception with more than one argument is raised
Reported by: | Nicolas Delaby | Owned by: | nobody |
---|---|---|---|
Component: | Testing framework | Version: | 2.0 |
Severity: | Release blocker | Keywords: | |
Cc: | Nicolas Delaby, Claude Paroz | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In case the exception instance accept more than one positional parameter to instantiate, the test client is failing to re-raise it.
Change History (12)
comment:1 by , 7 years ago
Cc: | added |
---|
comment:2 by , 7 years ago
Summary: | test client failed to expose Exceptions that requires more than one positional parameter → test client fail to expose Exceptions that require more than one positional parameter |
---|
comment:3 by , 7 years ago
Type: | Uncategorized → Bug |
---|
comment:4 by , 7 years ago
Cc: | added |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:7 by , 7 years ago
Easy pickings: | unset |
---|---|
Patch needs improvement: | set |
comment:8 by , 7 years ago
I think we should evaluate if simply replacing raise exc_info[0](exc_info[1]).with_traceback(exc_info[2])
by raise exc_info[1].with_traceback(exc_info[2])
would make it.
comment:9 by , 7 years ago
Patch needs improvement: | unset |
---|---|
Summary: | test client fail to expose Exceptions that require more than one positional parameter → test client crashes if an exception with more than one argument is raised |
I've updated the PR based on the discussion there.
comment:10 by , 7 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Note:
See TracTickets
for help on using tickets.
Regression introduced by 6e55e1d88a5c4453e25f0caf7ffb68973de5c0ba (refs #23919). It looks like there might be other instances that require adjustments
Do you think you could handle these as well? Also it looks like there's a lot of boilerplate involved to perform the re-reraise. Claude, do you have a better idea of how these should be handled?