Context Navigation

← Previous Ticket
Next Ticket →

#28722 closed Bug (fixed)

QuerySet.reverse() doesn't reverse nulls_first/nulls_last

Reported by:	Tomer Chachamu	Owned by:	Tim Graham <timograham@…>
Component:	Database layer (models, ORM)	Version:	1.11
Severity:	Normal	Keywords:
Cc:		Triage Stage:	Accepted
Has patch:	yes	Needs documentation:	no
Needs tests:	no	Patch needs improvement:	no
Easy pickings:	no	UI/UX:	no

Description

The documentation for Expression.reverse_ordering says it is its own inverse:

https://docs.djangoproject.com/en/1.11/ref/models/expressions/#django.db.models.Expression.reverse_ordering

Returns self with any modifications required to reverse the sort order within an order_by call. As an example, an expression implementing NULLS LAST would change its value to be NULLS FIRST. Modifications are only required for expressions that implement sort order like OrderBy. This method is called when reverse() is called on a queryset.

However, this isn't implemented.
https://github.com/django/django/blob/2b5a511bd9fbd67cedf72b8d39b9522c0140d023/django/db/models/expressions.py#L1133

Change History (8)

comment:1 by Tomer Chachamu, 7 years ago

Has patch:	set

comment:2 by Tomer Chachamu, 7 years ago

Owner:	Tomer Chachamu removed
Status:	assigned → new

comment:3 by Tim Graham, 7 years ago

Patch needs improvement:	set
Summary:	reverse_ordering does not reverse nulls_first/nulls_last → QuerySet.reverse() doesn't reverse nulls_first/nulls_last
Triage Stage:	Unreviewed → Accepted