Opened 7 years ago

Closed 7 years ago

#28465 closed Cleanup/optimization (fixed)

Unify index SQL creation code

Reported by: Claude Paroz Owned by: nobody
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently, database index creation may happen in two places:

  • Database.SchemaEditor._create_index_sql
  • Index.create_sql/Index.get_sql_create_template_values

I don't think it's a sane situation. We should decide who's responsible for index creation code and stick with it.

Change History (4)

comment:1 by Claude Paroz, 7 years ago

Has patch: set

​PR

comment:2 by Simon Charette, 7 years ago

Triage Stage: Unreviewed → Accepted

This is something ​I noticed as well when working on the deferred references stuff for #25530.

Thanks for tackling it Claude!

comment:3 by Tim Graham, 7 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Claude Paroz <claude@…>, 7 years ago

Resolution: → fixed
Status: new → closed

In 831358f:

Fixed #28465 -- Unified index SQL creation in DatabaseSchemaEditor

Thanks Tim Graham for the review.

Note: See TracTickets for help on using tickets.
Back to Top