Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#28074 closed Cleanup/optimization (fixed)

Document template-based widget rendering ramifications for contrib.gis

Reported by: Tobi Owned by: Tim Graham
Component: Documentation Version: 1.11
Severity: Normal Keywords: geodjango, templates
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

After upgrading from 1.10.7 to 1.11, OSMGeoAdmin with custom map_template throws a TemplateDoesNotExist error.

Consider an OSMGeoAdmin and a simple view:

class FieldAdmin(OSMGeoAdmin):
    map_template = 'gis/admin/hello_world.html'

def test_view(request):
    return render(request, 'gis/admin/hello_world.html', {})

The template is in project_dir/templates/gis/admin/hello_world.html, and the relevant settings are pretty default:

TEMPLATES = [
    {
        'BACKEND': 'django.template.backends.django.DjangoTemplates',
        'DIRS': [os.path.join(BASE_DIR, 'templates'),],
        'APP_DIRS': True,
        'OPTIONS': {
            ...
        },
    },
]

The test_view finds the template and renders fine, while the FieldAdmin cannot find the template. Interestingly, the filesystemloader is being used, but searches a completely wrong directory (ie definitely not my BASE_DIR):

django.template.loaders.filesystem.Loader: /home/ubuntu/env/lib/python3.5/site-packages/django/forms/templates/gis/admin/hello_world.html (Source does not exist)

Downgrading to 1.10.7 solves this issue.

Change History (5)

comment:1 by Tobi, 8 years ago

Summary: 1.11 GeoDjango admin template loaders change? → 1.11 GeoDjango admin template loaders broken?

comment:2 by Tim Graham, 8 years ago

Component: GIS → Documentation
Owner: changed from nobody to Tim Graham
Status: new → assigned
Summary: 1.11 GeoDjango admin template loaders broken? → Document template-based widget rendering ramifications for contrib.gis
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

There's a backwards-incompatible change that needs to be documented. These widgets now use ​the form rendering API. You can fix your project by using the TemplatesSetting renderer.

comment:3 by Tim Graham, 8 years ago

Has patch: set

​PR

comment:4 by GitHub <noreply@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 19a23fe:

Fixed #28074 -- Doc'd template-based widget rendering changes for contrib.gis.

comment:5 by Tim Graham <timograham@…>, 8 years ago

In e217e15:

[1.11.x] Fixed #28074 -- Doc'd template-based widget rendering changes for contrib.gis.

Backport of 19a23fe562b4b2d051612d2850834c60177c4063 from master

Note: See TracTickets for help on using tickets.
Back to Top