Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#27969 closed Bug (fixed)

models.Field.formfield() should allow the 'disabled' kwarg for fields with choices

Reported by: Moritz Pfeiffer Owned by: kapil garg
Component: Database layer (models, ORM) Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When calling the ​formfield() method for a modelfield with choices, the ​disabled keyword argument is not applied to the returned form field.

Change History (5)

comment:1 by Tim Graham, 8 years ago

Component: Uncategorized → Database layer (models, ORM)
Summary: The ModelField formfield() method should allow the 'disabled' kwarg for fields with choices → models.Field.formfield() should allow the 'disabled' kwarg for fields with choices
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

comment:2 by kapil garg, 8 years ago

Owner: changed from nobody to kapil garg
Status: new → assigned

comment:3 by kapil garg, 8 years ago

Has patch: set

​Pull Request

comment:4 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 7e09fa7f:

Fixed #27969 -- Fixed models.Field.formfield() setting 'disabled' for fields with choices.

comment:5 by Tim Graham <timograham@…>, 8 years ago

In a8c540ac:

[1.11.x] Fixed #27969 -- Fixed models.Field.formfield() setting 'disabled' for fields with choices.

Backport of 7e09fa7f519daf2f9c26587c3da5dc044d84b032 from master

Note: See TracTickets for help on using tickets.
Back to Top