Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#27920 closed Bug (fixed)

RadioSelect is not rendering the value attribute when it is empty

Reported by: Claude Paroz Owned by: Claude Paroz
Component: Forms Version: 1.11
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When a choice for a widgets.RadioSelect has an empty value, the rendered widget doesn't have the value property. This is not equivalent to value='' or even of a simple value. Some browsers at least default to value='on' when the attribute is absent.

Attachments (1)

27920-test.diff​ (965 bytes ) - added by Claude Paroz 8 years ago.
Failing modified test

Download all attachments as: .zip

Change History (7)

by Claude Paroz, 8 years ago

Attachment: 27920-test.diff​ added

Failing modified test

comment:1 by Claude Paroz, 8 years ago

Owner: changed from nobody to Claude Paroz
Status: new → assigned

comment:2 by Claude Paroz, 8 years ago

Has patch: set

​PR

comment:3 by Tim Graham, 8 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:4 by Claude Paroz <claude@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 540ae68:

Fixed #27920 -- Restored empty RadioSelect choice producing value=""

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.
Thanks Tim Graham for the review.

comment:5 by Claude Paroz <claude@…>, 8 years ago

In d8e90040:

[1.11.x] Fixed #27920 -- Restored empty RadioSelect choice producing value=""

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.
Thanks Tim Graham for the review.
Backport of 540ae68a5cc6339c72375fad9b04dc48f3af4c93 from master.

comment:6 by Claude Paroz <claude@…>, 8 years ago

In 70c5b8db:

[1.11.x] Refs #27920 -- Added missing encoding preamble on widget test file

Note: See TracTickets for help on using tickets.
Back to Top