Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#27822 closed Cleanup/optimization (fixed)

Audit Oracle's DatabaseIntrospection.data_types_reverse

Reported by: Tim Graham Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Mariusz Felisiak Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Some try/except catching for cx_Oracle.NATIVE_FLOAT and cx_Oracle.UNICODE is likely no longer needed (I suspect this was for older cx_Oracle support) and UNICODE usage might be replaced with other non-deprecated types as described in the ​5.2 release notes.

Change History (4)

comment:1 by Mariusz Felisiak, 8 years ago

Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned

comment:2 by Mariusz Felisiak, 8 years ago

Has patch: set

​PR

comment:3 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 1b96dbda:

Fixed #27822 -- Replaced deprecated cx_Oracle types in DatabaseIntrospection.data_types_reverse.

comment:4 by Tim Graham <timograham@…>, 8 years ago

In 1ed4dab:

[1.11.x] Fixed #27822 -- Replaced deprecated cx_Oracle types in DatabaseIntrospection.data_types_reverse.

Backport of 1b96dbdad0f9e65bf31764aa017f411d116682fc from master

Note: See TracTickets for help on using tickets.
Back to Top