Opened 8 years ago

Closed 8 years ago

#27723 closed Bug (fixed)

`type` is not propagated correctly to widgets in MultiWidgets

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: Forms Version: dev
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

If type is passed in attrs to MultiWidget then input HTML is incorrect e.g.:

<input name="date_0" type="date" type="text" />

instead of

<input name="date_0" type="date" />

Attachments (1)

27723.diff​ (1.5 KB ) - added by Mariusz Felisiak 8 years ago.

Download all attachments as: .zip

Change History (6)

by Mariusz Felisiak, 8 years ago

Attachment: 27723.diff​ added

comment:1 by Mariusz Felisiak, 8 years ago

It's a regression in #15667 that only affects master.

comment:2 by Mariusz Felisiak, 8 years ago

Has patch: set

​PR

comment:3 by Tim Graham, 8 years ago

Patch needs improvement: set
Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

In earlier versions of Django, passing attrs doesn't override the type in subwidgets. Solving #5851 to allow different attrs for different subwidgets might be a better solution.

comment:4 by Mariusz Felisiak, 8 years ago

Patch needs improvement: unset

comment:5 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 974d1453:

Fixed #27723 -- Set MultiWidget's subwidgets input type from attrs argument.

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

Note: See TracTickets for help on using tickets.
Back to Top