Opened 8 years ago

Closed 8 years ago

#27673 closed Bug (fixed)

System checks for contrib.admin are executed during registration

Reported by: Johannes Maron Owned by: Morgan Aubert
Component: contrib.admin Version: 1.10
Severity: Normal Keywords:
Cc: info@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As Tim and Florian mentioned:
​https://github.com/django/django/pull/6385#issuecomment-269658441

System checks for the admin are executed during app loading and the registration of ModelAdmins.
This is too early since some checks might rely on all ModelAdmins to be registered.

Change History (5)

comment:1 by Tim Graham, 8 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Morgan Aubert, 8 years ago

Owner: changed from nobody to Morgan Aubert
Status: new → assigned

comment:3 by Morgan Aubert, 8 years ago

Has patch: set

Added ​PR

comment:4 by Tim Graham, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In d57ecf4:

Fixed #27673 -- Made admin's checks run at check time instead of during registration.

Thanks Morgan Aubert for the test.

Note: See TracTickets for help on using tickets.
Back to Top