Specifying an order_with_respect_to for a self referential one to many relationship fails

[anonymous]

Code example follows. Basically I'm trying to create a tree heirarchy wherein a single category can be related to multiple sub categories which can be related to sub categories, etc.

The problem occurs when I try to make the default ordering use the parent category so as to keep all the categories grouped together.

The error I get is "'str' object has no attribute 'get_category_order'". I think this is because when the ForeignKey is used, the string "self" is passed in to make it self referential. But apparently the Meta class is not expecting this behavior. Any suggestions?

class Category(models.Model):
   class Admin:
      pass
      
   class Meta:
      order_with_respect_to = 'parent'
      
   is_active         = models.BooleanField(default=False)
   name              = models.CharField(maxlength=100)
   parent            = models.ForeignKey("self", blank=True,null=True)
   search_kewords    = models.TextField(blank=True)
   
   def __str__(self):
      if self.parent:
         prefix = str(self.parent)
      else:
         return self.name
         
      return '-->'.join((prefix,self.name))

[greg@…]

I just ran into this problem myself. Any chance on it being fixed in the next release or two?

[treeform]

me too - the custom sortable support sux in django. Any thing on this topic yet? How do we fix this?

[anonymous]

Related to #13

[Marty Alchin]

Moved the order_with_respect_to curried methods so that they're added after model resolution

[Marty Alchin]

I ran into this bug yesterday and decided to take a stab at a fix for it. This moves the methods related to order_with_respect_to so that they don't get installed until *after* the model is resolved, allowing 'self' references to be used with order_with_respect_to.

Technically this is slightly backwards-incompatible, though, but only in one specific scenario: If there is code listening for the class_prepared signal, and that code in turn expects these methods to be present, this patch may cause problems, because they won't necessarily be there.

Also included is a quick test to keep it from cropping up again.

[anonymous]

I'm not sure if your patch was intended as such, but it has no affect on the ordering of the items within the Admin (eg: within a select box)

[Jacob]

Also see #6402 for another patch.

[Kenneth Arnold]

update of patch for current trunk

[Kenneth Arnold]

I hit this bug myself, and updated the (almost trivial) patch for current SVN. I didn't copy over the testcase, but the one from the original patch should be fine.

[mushy]

any news for this bug ?

[Werner Beroux]

Still having this issue. It was working right before 1.0 and now even with 1.02 still not working.

Seems another guy also has the problem ​http://groups.google.com/group/django-developers/browse_thread/thread/280bca5001faca07

[thefekete]

Also having exact same problem with 1.1.1, anybody have a work around?

[thefekete]

I figured out a work-around to auto-update a sort field on save. You can see the details here:

​http://thefekete.net/blog/sorting-hierarchical-categories-in-django/

[Adam Nelson]

The code is fine - not sure if it makes sense anymore or if something like this should be added to contrib:

​http://www.eflorenzano.com/blog/post/exploring-mixins-django-model-inheritance/

Nonetheless, ready for a core-contributor to take to the next step.

[Malcolm Tredinnick]

Just because there might not be any existing tests for order_with_respect_to doesn't mean this patch gets away without writing some. No patch goes in without tests, so we need that for this case. Test case should fail before the main body changes are applied and pass afterwards, of course.

[Kyle Dodson]

It looks like this has been fixed by #13241.