Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#27261 closed Bug (fixed)

Missing python-brace-format marker for a contrib.admin string

Reported by: Maxime Vdb Owned by: Claude Paroz
Component: contrib.admin Version: 1.10
Severity: Normal Keywords: translation japanese admin
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

Hi there,

I found out there is a mismatch in the placeholders between a translation message id and its actual translation in Japanese. You can find the strings here (here is the code that uses this string).

I don't know what is your process to do that but I'll be glad to help. Also, I discovered that because we have unit-tests that compare the strings and their translations and look for mismatches in their placeholders. We could easily implement such a unit test in Django itself.

Change History (4)

comment:1 by Tim Graham, 8 years ago

Easy pickings: unset
Type: UncategorizedBug

Translations are done through Transifex. Assuming this can be fixed there, then you can close the ticket as we don't use Trac to coordinate that work.

comment:2 by Claude Paroz, 8 years ago

Owner: changed from nobody to Claude Paroz
Status: newassigned
Summary: Mismatch for placholders in japanese translations (django.contrib.admin app)Missing python-brace-format marker for a contrib.admin string
Triage Stage: UnreviewedAccepted

As Tim said, you should fix the string on Transifex.
However, this reveals a bug in that the offended original string misses the #, python-brace-format marker in the base en/LC_MESSAGES/django.po. I'll fix that.
With the proper marker, this error should have been caught by the gettext check program (msgfmt -vc).

comment:3 by Claude Paroz <claude@…>, 8 years ago

Resolution: fixed
Status: assignedclosed

In 2c50120:

Fixed #27261 -- Added missing python-brace-format marker

Thanks Maxime Vdb for the report.

comment:4 by Claude Paroz <claude@…>, 8 years ago

In 90949a15:

[1.10.x] Fixed #27261 -- Added missing python-brace-format marker

Thanks Maxime Vdb for the report.
Backport of 2c501203601c9610e69155c57bfe235f155344e2 from master.

Note: See TracTickets for help on using tickets.
Back to Top