Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#27175 closed Cleanup/optimization (fixed)

Deprecate silencing exceptions raised while rendering the {% include %} template tag

Reported by: Jon Dufresne Owned by: nobody
Component: Template system Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Django developers discussion ​https://groups.google.com/d/topic/django-developers/hscW1VboJxY

As proposed and supported in the linked discussion, deprecate the silencing of exceptions while rending the {% include %} template tag.

As this silencing behavior only occurs when template.debug=True, it is difficult to rely on this as a "feature". Further, the behavior could silence actual bugs during development as well as lead to a different error reporting path when used in production. (e.g. Errors are reported through Django template logging instead of through Sentry.)

Change History (6)

comment:1 by Jon Dufresne, 8 years ago

Has patch: set

​PR

comment:2 by Tim Graham, 8 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by GitHub <noreply@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 331ca53:

Fixed #27175 -- Deprecated silencing exceptions from the {% include %} template tag.

Thanks Tim Graham for the review.

comment:5 by Tim Graham <timograham@…>, 7 years ago

In e62165b:

Refs #27175 -- Removed exception silencing from the {% include %} template tag.

Per deprecation timeline.

comment:6 by Tim Graham <timograham@…>, 7 years ago

In 058d112:

Refs #27175 -- Removed an obsolete test comment and DEBUG=True.

As of e62165b898785e890661953c3b2c9c36d98aee57, {% include %}
doesn't silence exceptions.

Note: See TracTickets for help on using tickets.
Back to Top