i18n_patterns returns tuple instead of list

[Alex Hill]

In Django 1.10, i18n_patterns() returns a tuple when USE_I18N is False.

I think it should always return a list, given the docs prescribe the use of lists for urlpatterns:

urlpatterns should be a Python list of url() instances.

As it stands the example given for the usage of i18n_patterns() wouldn't work with i18n disabled:

from django.conf.urls import include, url
from django.conf.urls.i18n import i18n_patterns

from about import views as about_views
from news import views as news_views
from sitemap.views import sitemap

urlpatterns = [
    url(r'^sitemap\.xml$', sitemap, name='sitemap-xml'),
]

news_patterns = ([
    url(r'^$', news_views.index, name='index'),
    url(r'^category/(?P<slug>[\w-]+)/$', news_views.category, name='category'),
    url(r'^(?P<slug>[\w-]+)/$', news_views.details, name='detail'),
], 'news')

urlpatterns += i18n_patterns(
    url(r'^about/$', about_views.main, name='about'),
    url(r'^news/', include(news_patterns, namespace='news')),
)

[Markus Holtermann <info@…>]

In 9711207:

Fixed #26945 -- Ensured that i18n_patterns returns a list

[Markus Holtermann <info@…>]

In 4e8ccb32:

[1.10.x] Fixed #26945 -- Ensured that i18n_patterns returns a list

Backport of 971120778a7e7b7ebc2fc48275cca20a87580efe from master