Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#26897 closed Bug (fixed)

makemessages crash with non ascii file names

Reported by: Claude Paroz Owned by: Claude Paroz
Component: Internationalization Version: 1.9
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

On Python 2:

...
  File "/home/claude/virtualenvs/djangogit/local/lib/python2.7/site-packages/django/core/management/commands/makemessages.py", line 393, in build_potfiles
    self.process_files(file_list)
  File "/home/claude/virtualenvs/djangogit/local/lib/python2.7/site-packages/django/core/management/commands/makemessages.py", line 488, in process_files
    self.process_locale_dir(locale_dir, files)
  File "/home/claude/virtualenvs/djangogit/local/lib/python2.7/site-packages/django/core/management/commands/makemessages.py", line 552, in process_locale_dir
    input_files_list.write('\n'.join(input_files))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 233: ordinal not in range(128)

Change History (9)

comment:1 by Claude Paroz, 8 years ago

Has patch: set

​PR

comment:2 by Tim Graham, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:3 by Claude Paroz <claude@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 3e71f654:

Fixed #26897 -- Fixed makemessages crash on Python 2 with non-ASCII file names

Thanks Tim Graham for the review.

comment:4 by Claude Paroz <claude@…>, 8 years ago

In 96a37a02:

[1.10.x] Fixed #26897 -- Fixed makemessages crash on Python 2 with non-ASCII file names

Thanks Tim Graham for the review.
Backport of 3e71f6544feca490211e88db4f449dfdb7acce39 from master.

comment:5 by Claude Paroz <claude@…>, 8 years ago

In a74adb4c:

[1.9.x] Fixed #26897 -- Fixed makemessages crash on Python 2 with non-ASCII file names

Thanks Tim Graham for the review.
Backport of 3e71f6544feca490211e88db4f449dfdb7acce39 from master.

comment:6 by Claude Paroz <claude@…>, 8 years ago

In 208eead7:

[1.10.x] Refs #26897 -- Missing directory containment in i18n test

comment:7 by Claude Paroz <claude@…>, 8 years ago

In e1a60f2e:

[1.9.x] Refs #26897 -- Missing directory containment in i18n test

comment:8 by Claude Paroz <claude@…>, 8 years ago

In de9af391:

[1.10.x] Refs #26897 -- Added cleanup to i18n test

comment:9 by Claude Paroz <claude@…>, 8 years ago

In ab2f5f76:

[1.9.x] Refs #26897 -- Added cleanup to i18n test

Note: See TracTickets for help on using tickets.
Back to Top