#2663 closed defect (fixed)
[patch] [per-object-permissions] pop admin broken
| Reported by: | Joeboy | Owned by: | Chris Long |
|---|---|---|---|
| Component: | contrib.admin | Version: | |
| Severity: | normal | Keywords: | per-object-permissions, row-level |
| Cc: | django25@… | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I guess this is my fault for using unmerged branches, but this all looks a bit broken to me.
row_level_perm_manipulator contains the following:
if str(value) == str_data:
selected_html = ' selected="selected"'
which is supposed to set the default value of the user/group boxes. However at this point, value contains things like 'group-3' and str_data contains things like 'auth/group/3'. Consequently the boxes always default to 'admin'.
Attachments (1)
Change History (5)
by , 18 years ago
| Attachment: | pop-admin-fix.patch added |
|---|
comment:1 by , 18 years ago
| Summary: | [per-object-permissions] pop admin broken → [patch] [per-object-permissions] pop admin broken |
|---|
comment:2 by , 18 years ago
| Owner: | changed from to |
|---|
comment:3 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 by , 18 years ago
More my fault for not properly testing the code, learned my lesson that no matter how simple the fix seems it can still break countless things.
Changed it now so it uses the returnKey method which removes the problem and removes the chance of this happening in the future.
Note:
See TracTickets
for help on using tickets.
I have no idea if this is the right fix or not, but it appears to 'work' as far as I can tell.