Context Navigation

← Previous Ticket
Next Ticket →

#26126 closed Cleanup/optimization (fixed)

Transient failure of requests.tests.RequestsTests.test_max_age_expiration

Reported by:	Simon Charette	Owned by:	Berker Peksag
Component:	Testing framework	Version:	dev
Severity:	Normal	Keywords:
Cc:	berker.peksag@…	Triage Stage:	Ready for checkin
Has patch:	yes	Needs documentation:	no
Needs tests:	no	Patch needs improvement:	no
Easy pickings:	no	UI/UX:	no

Description

Traceback (most recent call last):
  File "/home/jenkins/workspace/pull-requests-trusty/database/postgis/label/trusty-pr/python/python2.7/tests/requests/tests.py", line 240, in test_max_age_expiration
    self.assertEqual(max_age_cookie['expires'], cookie_date(time.time() + 10))
AssertionError: u'Fri, 22-Jan-2016 19:44:54 GMT' != u'Fri, 22-Jan-2016 19:44:55 GMT'
- Fri, 22-Jan-2016 19:44:54 GMT
?                         ^
+ Fri, 22-Jan-2016 19:44:55 GMT
?                         ^

Change History (7)

comment:1 by Berker Peksag, 9 years ago

Cc:	berker.peksag@… added
Has patch:	set
Owner:	changed from nobody to Berker Peksag
Status:	new → assigned

Pull request: https://github.com/django/django/pull/6130

Alternative solutions:

Make assertEqual check less strict: Don't check for the exact return value of cookie_date().
Convert assertEqual to assertIn and check if the return value is time.time() + 10 + 1 or time.time() + 10 - 1. This is simpler than the first solution.
Mock cookie_date() in HttpResponseBase.set_cookie().