Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#26024 closed Bug (fixed)

ConditionalGetMiddleware's ETag is broken

Reported by: Sami Fahed Owned by: Sami Fahed
Component: Core (Cache system) Version: 1.9
Severity: Release blocker Keywords: Etags
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Sami Fahed)

ETag support is broken in ConditionalGetMiddleware

django.utils.cache.get_conditional_response's etag argument needs to be *unquoted*, however the etag passed by CommonMiddleware's make_response is quoted or the GZipMiddleware is modifying it while keeping it quoted.

Pull request with Regression Test: ​https://github.com/django/django/pull/5919

Change History (4)

comment:1 by Sami Fahed, 9 years ago

Description: modified (diff)

comment:2 by Tim Graham, 9 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: new → closed

In 186b6c61:

Fixed #26024 -- Fixed regression in ConditionalGetMiddleware ETag support.

Thanks Denis Cornehl for help with the patch.

comment:4 by Tim Graham <timograham@…>, 9 years ago

In ee2835e6:

[1.9.x] Fixed #26024 -- Fixed regression in ConditionalGetMiddleware ETag support.

Backport of 186b6c61bfe85afa4d6bf213d04a28dd2853fed2 from master

Note: See TracTickets for help on using tickets.
Back to Top