Opened 9 years ago
Closed 9 years ago
#25989 closed Bug (fixed)
sitemap view picks lastmod from last supplied sitemap only
| Reported by: | allixx | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.sitemaps | Version: | dev |
| Severity: | Normal | Keywords: | sitemap lastmod |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
When passing several sitemaps as a parameter to sitemap view, only last sitemap's lastmod is used for 'Last-Modified' response header.
Maximum lastmod should be picked from all passed sitemaps lasmods instead.
The same problem exists in 1.8 and 1.9.
Attachments (1)
Change History (9)
by , 9 years ago
| Attachment: | views.py.diff added |
|---|
comment:1 by , 9 years ago
| Has patch: | set |
|---|---|
| Needs tests: | set |
| Triage Stage: | Unreviewed → Accepted |
Please uncheck "Needs tests" if you can add them to the pull request.
comment:2 by , 9 years ago
| Needs tests: | unset |
|---|
comment:3 by , 9 years ago
| Needs tests: | set |
|---|
comment:6 by , 9 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
should this be back-ported to 1.8+ ?
comment:7 by , 9 years ago
I think this isn't a critical bug to backport. The sitemap Last-Modified header functionality is new in Django 1.7 -- if it had been reported shortly after that release it would be easier to justify a backport.
Note:
See TracTickets
for help on using tickets.
django/contrib/sitemaps/views.py