Opened 9 years ago

Closed 8 years ago

#25898 closed Bug (fixed)

test database creation on Oracle mistakes privilege error for existing database

Reported by: JorisBenschop Owned by: Mariusz Felisiak
Component: Testing framework Version: 1.9
Severity: Normal Keywords: oracle test
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

If I run "manage.py test" on Oracle 12 the following occurs:

$ ./manage.py test
Creating test database for alias 'default'...
Failed (ORA-01031: insufficient privileges
)
Got an error creating the test database: ORA-01031: insufficient privileges

It appears the test database, test_GFJOM_prada_, already exists. Type 'yes' to delete it, or 'no' to cancel:

To me this seems that the error ('you are not allowed to create a db because you have no privs for that" is mistaken for "the db already exists thus you cannot make it"

Change History (7)

comment:1 by JorisBenschop, 9 years ago

Summary: manage.py test mistakes privilege error for existing databas → manage.py test mistakes privilege error for existing database

comment:2 by Aymeric Augustin, 9 years ago

As a workaround, you can try manage.py test --keep-db. I'm not saying this is the ideal resolution of this ticket. I'm just trying to give you a way forwards while we figure out a solution.

comment:3 by Tim Graham, 9 years ago

Summary: manage.py test mistakes privilege error for existing database → test database creation on Oracle mistakes privilege error for existing database
Triage Stage: Unreviewed → Accepted

Code in question: ​https://github.com/django/django/blob/1aa8bf9b43bbc214770389b9b8d084552040fa44/django/db/backends/oracle/creation.py#L37-L48

comment:4 by Mariusz Felisiak, 8 years ago

Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned

comment:5 by Mariusz Felisiak, 8 years ago

Has patch: set

​PR

comment:6 by Shai Berger, 8 years ago

Triage Stage: Accepted → Ready for checkin

I think the PR is almost good to go, left minor style comments.

comment:7 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 965f678a:

Fixed #25898 -- Made test database/user creation on Oracle reraise unexpected errors.

Thanks Shai Berger and Tim Graham for review.

Note: See TracTickets for help on using tickets.
Back to Top